Browse Source

Address SonarLint findings in SectionPairFileReader class

Patrick-Christopher Mattulat 1 year ago
parent
commit
97e26afd40

+ 2 - 3
source/ls-std/io/section-pair/reader/SectionPairFileReader.cpp

@@ -3,7 +3,7 @@
 * Company:         Lynar Studios
 * E-Mail:          webmaster@lynarstudios.com
 * Created:         2023-02-21
-* Changed:         2023-02-23
+* Changed:         2023-05-16
 *
 * */
 
@@ -31,9 +31,8 @@ using std::make_shared;
 using std::shared_ptr;
 using std::string;
 
-SectionPairFileReader::SectionPairFileReader(const SectionPairFileReaderParameter &_parameter) : Class("SectionPairFileReader")
+SectionPairFileReader::SectionPairFileReader(const SectionPairFileReaderParameter &_parameter) : Class("SectionPairFileReader"), parameter(_parameter)
 {
-  this->parameter = _parameter;
   ConditionalFunctionExecutor{this->parameter.getFileExistenceEvaluator() == nullptr}.execute([this] { _createFileExistenceEvaluator(); });
   this->parameter.getFileExistenceEvaluator()->evaluate();
   this->_checkFileExtension();

+ 2 - 2
test/cases/io/section-pair/reader/SectionPairFileReaderIT.cpp

@@ -3,7 +3,7 @@
 * Company:         Lynar Studios
 * E-Mail:          webmaster@lynarstudios.com
 * Created:         2023-02-21
-* Changed:         2023-03-25
+* Changed:         2023-05-16
 *
 * */
 
@@ -40,7 +40,7 @@ namespace
   TEST_F(SectionPairFileReaderIT, read)
   {
     SectionPairFileReaderParameter parameter{};
-    shared_ptr<SectionPairDocument> document = make_shared<SectionPairDocument>();
+    auto document = make_shared<SectionPairDocument>();
     parameter.setDocument(document);
     parameter.setFilePath(SectionPairFileReaderIT::getSectionPairFileLocation());
     SectionPairFileReader reader{parameter};