Pārlūkot izejas kodu

Address SonarLint findings in JniClassParameter class

Patrick-Christopher Mattulat 1 gadu atpakaļ
vecāks
revīzija
ec9e295686

+ 2 - 2
include/ls-std/core/jni/JniClassParameter.hpp

@@ -3,7 +3,7 @@
 * Company:         Lynar Studios
 * E-Mail:          webmaster@lynarstudios.com
 * Created:         2023-04-07
-* Changed:         2023-04-10
+* Changed:         2023-05-16
 *
 * */
 
@@ -27,7 +27,7 @@ namespace ls::std::core::experimental
 
       [[nodiscard]] JNIEnv *getJavaEnvironment();
       [[nodiscard]] jobject getJavaObject();
-      [[nodiscard]] ::std::shared_ptr<ls::std::core::experimental::interface_type::IJniApi> getJniApi();
+      [[nodiscard]] ::std::shared_ptr<ls::std::core::experimental::interface_type::IJniApi> getJniApi() const;
       void setJavaEnvironment(JNIEnv *_environment);
       void setJavaObject(jobject _javaObject);
       void setJniApi(const ::std::shared_ptr<ls::std::core::experimental::interface_type::IJniApi> &_jniApi);

+ 2 - 2
source/ls-std/core/jni/JniClassParameter.cpp

@@ -3,7 +3,7 @@
 * Company:         Lynar Studios
 * E-Mail:          webmaster@lynarstudios.com
 * Created:         2023-04-07
-* Changed:         2023-04-10
+* Changed:         2023-05-16
 *
 * */
 
@@ -28,7 +28,7 @@ jobject JniClassParameter::getJavaObject()
   return this->javaObject;
 }
 
-shared_ptr<IJniApi> JniClassParameter::getJniApi()
+shared_ptr<IJniApi> JniClassParameter::getJniApi() const
 {
   return this->jniApi;
 }

+ 3 - 3
test/cases/core/jni/JniClassParameterTest.cpp

@@ -3,7 +3,7 @@
 * Company:         Lynar Studios
 * E-Mail:          webmaster@lynarstudios.com
 * Created:         2023-04-07
-* Changed:         2023-04-10
+* Changed:         2023-05-16
 *
 * */
 
@@ -51,7 +51,7 @@ namespace
   TEST_F(JniClassParameterTest, setJavaEnvironment)
   {
     JniClassParameter parameter{};
-    shared_ptr<JNIEnv> environment = make_shared<JNIEnv>();
+    auto environment = make_shared<JNIEnv>();
     parameter.setJavaEnvironment(environment.get());
 
     ASSERT_TRUE(parameter.getJavaEnvironment() == environment.get());
@@ -60,7 +60,7 @@ namespace
   TEST_F(JniClassParameterTest, setJavaObject)
   {
     JniClassParameter parameter{};
-    shared_ptr<_jobject> javaObject = make_shared<_jobject>();
+    auto javaObject = make_shared<_jobject>();
     parameter.setJavaObject(javaObject.get());
 
     ASSERT_TRUE(parameter.getJavaObject() == javaObject.get());