Browse Source

Address SonarLint findings in Event like classes

Patrick-Christopher Mattulat 1 year ago
parent
commit
b3d205a5e2

+ 3 - 2
include/ls-std/core/type/EventTypes.hpp

@@ -3,13 +3,14 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2020-11-26
- * Changed:         2023-02-08
+ * Changed:         2023-05-17
  *
  * */
 
 #ifndef LS_STD_EVENT_TYPES_HPP
 #define LS_STD_EVENT_TYPES_HPP
 
+#include <functional>
 #include <map>
 #include <string>
 #include <vector>
@@ -20,7 +21,7 @@ namespace ls::std::core::type
   using event_parameter_id = ::std::string;
   using event_parameter_value = ::std::string;
   using event_parameter = ::std::pair<::std::string, ::std::string>;
-  using event_parameter_list = ::std::map<ls::std::core::type::event_parameter_id, ls::std::core::type::event_parameter_value>;
+  using event_parameter_list = ::std::map<ls::std::core::type::event_parameter_id, ls::std::core::type::event_parameter_value, ::std::less<>>;
 }
 
 #endif

+ 2 - 2
include/ls-std/event/EventHandler.hpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2020-11-27
- * Changed:         2023-02-22
+ * Changed:         2023-05-17
  *
  * */
 
@@ -27,7 +27,7 @@ namespace ls::std::event
       explicit EventHandler(const ls::std::core::type::event_id &_id);
       ~EventHandler() noexcept override;
 
-      [[nodiscard]] ls::std::core::type::event_id getId();
+      [[nodiscard]] ls::std::core::type::event_id getId() const;
 
     private:
 

+ 2 - 2
include/ls-std/event/EventManager.hpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2020-11-27
- * Changed:         2023-05-16
+ * Changed:         2023-05-17
  *
  * */
 
@@ -35,7 +35,7 @@ namespace ls::std::event
       // additional functionality
 
       bool addEventHandler(const ::std::shared_ptr<ls::std::event::EventHandler> &_eventHandler); // nodiscard is optional here
-      void fire(ls::std::event::Event _event);
+      void fire(const ls::std::event::Event &_event);
       [[nodiscard]] bool hasEventHandler(const ls::std::core::type::event_id &_id);
       bool removeEventHandler(const ::std::shared_ptr<ls::std::event::EventHandler> &_eventHandler); // nodiscard is optional here
 

+ 2 - 2
source/ls-std/event/EventHandler.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2020-11-27
- * Changed:         2023-02-23
+ * Changed:         2023-05-17
  *
  * */
 
@@ -22,7 +22,7 @@ EventHandler::EventHandler(const event_id &_id) : Narrator()
 
 EventHandler::~EventHandler() noexcept = default;
 
-event_id EventHandler::getId()
+event_id EventHandler::getId() const
 {
   return this->id;
 }

+ 2 - 2
source/ls-std/event/EventManager.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2020-11-27
- * Changed:         2023-02-23
+ * Changed:         2023-05-17
  *
  * */
 
@@ -72,7 +72,7 @@ bool EventManager::addEventHandler(const shared_ptr<EventHandler> &_eventHandler
   return wasAdded;
 }
 
-void EventManager::fire(Event _event)
+void EventManager::fire(const Event &_event)
 {
   if (this->_hasEventHandler(_event.getId()))
   {