Centralize engine status codes

include/core/StatusCodeOk.hpp

@@ -8,7 +8,6 @@
 
 #include <Export.hpp>
 #include <interface/AStatusCode.hpp>
-#include <string>
 
 namespace ls::atlantis::core
 {

include/core/StatusCodes.hpp

@@ -0,0 +1,17 @@
+/*
+ * author: Patrick-Christopher Mattulat
+ * e-mail: webmaster@lynarstudios.com
+ */
+
+#ifndef LS_ATLANTIS_ENGINE_STATUS_CODES_HPP
+#define LS_ATLANTIS_ENGINE_STATUS_CODES_HPP
+
+namespace ls::atlantis::core
+{
+  enum StatusCodes
+  {
+    OK = 1
+  };
+}
+
+#endif

source/core/StatusCodeOk.cpp

@@ -4,13 +4,14 @@
  */
 
 #include <core/StatusCodeOk.hpp>
+#include <core/StatusCodes.hpp>
 
 using ls::atlantis::core::StatusCodeOk;
 using ls::atlantis::interfaces::AStatusCode;
 using ::std::move;
 using ::std::string;
 
-StatusCodeOk::StatusCodeOk() : AStatusCode(1, "ok")
+StatusCodeOk::StatusCodeOk() : AStatusCode(StatusCodes::OK, "ok")
 {}
 
 StatusCodeOk::~StatusCodeOk() = default;

test/core/StatusCodeOkTest.cpp

@@ -4,9 +4,11 @@
  */
 
 #include <core/StatusCodeOk.hpp>
+#include <core/StatusCodes.hpp>
 #include <gtest/gtest.h>
 
 using ls::atlantis::core::StatusCodeOk;
+using ls::atlantis::core::StatusCodes;
 using ::std::string;
 using ::testing::Test;
 
@@ -22,7 +24,7 @@ namespace
 
   TEST_F(StatusCodeOkTest, getId)
   {
-    ASSERT_EQ(1, StatusCodeOk().getId());
+    ASSERT_EQ(StatusCodes::OK, StatusCodeOk().getId());
   }
 
   TEST_F(StatusCodeOkTest, getText)