Parcourir la source

Improve variable naming in serializable json factories

Patrick-Christopher Mattulat il y a 3 ans
Parent
commit
5343fc493c

+ 7 - 7
source/ls_std/factory/serialization/SerializableJSONFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-24
- * Changed:         2021-04-25
+ * Changed:         2021-04-30
  *
  * */
 
@@ -30,7 +30,7 @@ ls_std::SerializableJSONFactory::SerializableJSONFactory() : ls_std::Class("Seri
 
 bool ls_std::SerializableJSONFactory::addFactory(const std::pair<std::string, std::shared_ptr<ls_std::IFactory>> &_factoryInsertion)
 {
-  bool hasFactory{};
+  bool factoryAdded{};
 
   if (_factoryInsertion.first.empty())
   {
@@ -44,22 +44,22 @@ bool ls_std::SerializableJSONFactory::addFactory(const std::pair<std::string, st
 
   if (!this->_hasFactory(_factoryInsertion.first))
   {
-    hasFactory = this->factories.insert(_factoryInsertion).second;
+    factoryAdded = this->factories.insert(_factoryInsertion).second;
   }
 
-  return hasFactory;
+  return factoryAdded;
 }
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONFactory::build(const std::string &_relatedObjectName)
 {
-  std::shared_ptr<ls_std::Class> requestedObject{};
+  std::shared_ptr<ls_std::Class> requestedBuiltObject{};
 
   if (this->_hasFactory(_relatedObjectName))
   {
-    requestedObject = this->factories.at(_relatedObjectName)->build();
+    requestedBuiltObject = this->factories.at(_relatedObjectName)->build();
   }
 
-  return requestedObject;
+  return requestedBuiltObject;
 }
 
 bool ls_std::SerializableJSONFactory::clear()

+ 5 - 5
source/ls_std/factory/serialization/boxing/SerializableJSONBooleanFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-23
- * Changed:         2021-04-23
+ * Changed:         2021-04-30
  *
  * */
 
@@ -16,9 +16,9 @@ ls_std::SerializableJSONBooleanFactory::SerializableJSONBooleanFactory() : ls_st
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONBooleanFactory::build()
 {
-  std::shared_ptr<ls_std::Boolean> value = std::make_shared<ls_std::Boolean>();
-  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONBoolean>(value);
-  value->setSerializable(serializable);
+  std::shared_ptr<ls_std::Boolean> requestedObject = std::make_shared<ls_std::Boolean>();
+  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONBoolean>(requestedObject);
+  requestedObject->setSerializable(serializable);
 
-  return std::dynamic_pointer_cast<ls_std::Class>(value);
+  return std::dynamic_pointer_cast<ls_std::Class>(requestedObject);
 }

+ 5 - 5
source/ls_std/factory/serialization/boxing/SerializableJSONDoubleFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-24
- * Changed:         2021-04-24
+ * Changed:         2021-04-30
  *
  * */
 
@@ -16,9 +16,9 @@ ls_std::SerializableJSONDoubleFactory::SerializableJSONDoubleFactory() : ls_std:
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONDoubleFactory::build()
 {
-  std::shared_ptr<ls_std::Double> value = std::make_shared<ls_std::Double>();
-  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONDouble>(value);
-  value->setSerializable(serializable);
+  std::shared_ptr<ls_std::Double> requestedObject = std::make_shared<ls_std::Double>();
+  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONDouble>(requestedObject);
+  requestedObject->setSerializable(serializable);
 
-  return std::dynamic_pointer_cast<ls_std::Class>(value);
+  return std::dynamic_pointer_cast<ls_std::Class>(requestedObject);
 }

+ 5 - 5
source/ls_std/factory/serialization/boxing/SerializableJSONFloatFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-25
- * Changed:         2021-04-25
+ * Changed:         2021-04-30
  *
  * */
 
@@ -16,9 +16,9 @@ ls_std::SerializableJSONFloatFactory::SerializableJSONFloatFactory() : ls_std::C
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONFloatFactory::build()
 {
-  std::shared_ptr<ls_std::Float> value = std::make_shared<ls_std::Float>();
-  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONFloat>(value);
-  value->setSerializable(serializable);
+  std::shared_ptr<ls_std::Float> requestedObject = std::make_shared<ls_std::Float>();
+  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONFloat>(requestedObject);
+  requestedObject->setSerializable(serializable);
 
-  return std::dynamic_pointer_cast<ls_std::Class>(value);
+  return std::dynamic_pointer_cast<ls_std::Class>(requestedObject);
 }

+ 5 - 5
source/ls_std/factory/serialization/boxing/SerializableJSONIntegerFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-25
- * Changed:         2021-04-25
+ * Changed:         2021-04-30
  *
  * */
 
@@ -16,9 +16,9 @@ ls_std::SerializableJSONIntegerFactory::SerializableJSONIntegerFactory() : ls_st
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONIntegerFactory::build()
 {
-  std::shared_ptr<ls_std::Integer> value = std::make_shared<ls_std::Integer>();
-  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONInteger>(value);
-  value->setSerializable(serializable);
+  std::shared_ptr<ls_std::Integer> requestedObject = std::make_shared<ls_std::Integer>();
+  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONInteger>(requestedObject);
+  requestedObject->setSerializable(serializable);
 
-  return std::dynamic_pointer_cast<ls_std::Class>(value);
+  return std::dynamic_pointer_cast<ls_std::Class>(requestedObject);
 }

+ 5 - 5
source/ls_std/factory/serialization/boxing/SerializableJSONLongFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-25
- * Changed:         2021-04-25
+ * Changed:         2021-04-30
  *
  * */
 
@@ -16,9 +16,9 @@ ls_std::SerializableJSONLongFactory::SerializableJSONLongFactory() : ls_std::Cla
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONLongFactory::build()
 {
-  std::shared_ptr<ls_std::Long> value = std::make_shared<ls_std::Long>();
-  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONLong>(value);
-  value->setSerializable(serializable);
+  std::shared_ptr<ls_std::Long> requestedObject = std::make_shared<ls_std::Long>();
+  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONLong>(requestedObject);
+  requestedObject->setSerializable(serializable);
 
-  return std::dynamic_pointer_cast<ls_std::Class>(value);
+  return std::dynamic_pointer_cast<ls_std::Class>(requestedObject);
 }

+ 5 - 5
source/ls_std/factory/serialization/boxing/SerializableJSONStringFactory.cpp

@@ -3,7 +3,7 @@
  * Company:         Lynar Studios
  * E-Mail:          webmaster@lynarstudios.com
  * Created:         2021-04-25
- * Changed:         2021-04-25
+ * Changed:         2021-04-30
  *
  * */
 
@@ -16,9 +16,9 @@ ls_std::SerializableJSONStringFactory::SerializableJSONStringFactory() : ls_std:
 
 std::shared_ptr<ls_std::Class> ls_std::SerializableJSONStringFactory::build()
 {
-  std::shared_ptr<ls_std::String> value = std::make_shared<ls_std::String>();
-  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONString>(value);
-  value->setSerializable(serializable);
+  std::shared_ptr<ls_std::String> requestedObject = std::make_shared<ls_std::String>();
+  std::shared_ptr<ls_std::ISerializable> serializable = std::make_shared<ls_std::SerializableJSONString>(requestedObject);
+  requestedObject->setSerializable(serializable);
 
-  return std::dynamic_pointer_cast<ls_std::Class>(value);
+  return std::dynamic_pointer_cast<ls_std::Class>(requestedObject);
 }