Browse Source

Fix security issues within jni code basis

Patrick-Christopher Mattulat 6 hours ago
parent
commit
217fecf77e

+ 5 - 5
source/ls-std/time/system-time/jni/com_lynarstudios_ls_std_time_systemtime_SystemTimeJni.cpp

@@ -3,7 +3,7 @@
 * Company:         Lynar Studios
 * Company:         Lynar Studios
 * E-Mail:          webmaster@lynarstudios.com
 * E-Mail:          webmaster@lynarstudios.com
 * Created:         2023-03-16
 * Created:         2023-03-16
-* Changed:         2023-05-19
+* Changed:         2025-12-22
 *
 *
 * */
 * */
 
 
@@ -37,7 +37,7 @@ using std::string;
 
 
 JNIEXPORT jboolean JNICALL Java_com_lynarstudios_ls_std_time_systemtime_SystemTimeJni_set(JNIEnv *_environment, [[maybe_unused]] jobject _object, jobject _dateParameter)
 JNIEXPORT jboolean JNICALL Java_com_lynarstudios_ls_std_time_systemtime_SystemTimeJni_set(JNIEnv *_environment, [[maybe_unused]] jobject _object, jobject _dateParameter)
 {
 {
-  auto parameter = make_shared<JniClassParameter>();
+  const auto parameter = make_shared<JniClassParameter>();
   parameter->setJavaEnvironment(_environment);
   parameter->setJavaEnvironment(_environment);
   parameter->setJavaObject(_dateParameter);
   parameter->setJavaObject(_dateParameter);
 
 
@@ -53,12 +53,12 @@ JNIEXPORT jboolean JNICALL Java_com_lynarstudios_ls_std_time_systemtime_SystemTi
 
 
   // map
   // map
 
 
-  DateParameter dateParameter = JniDateParameterMapper::toDateParameter(javaClass);
-  bool success = SystemTime{}.set(dateParameter);
+  const DateParameter dateParameter = JniDateParameterMapper::toDateParameter(javaClass);
+  const bool success = SystemTime{}.set(dateParameter);
 
 
   if (success)
   if (success)
   {
   {
-    cout << R"lit(system time successfully set to ")lit" << dateParameter.getYear() << "-" << (int) dateParameter.getMonth() << "-" << (int) dateParameter.getDay() << " " << (int) dateParameter.getHour() << ":" << (int) dateParameter.getMinute() << ":" << (int) dateParameter.getSecond() << R"lit(" ...)lit" << endl;
+    cout << R"lit(system time successfully set to ")lit" << dateParameter.getYear() << "-" << dateParameter.getMonth() << "-" << dateParameter.getDay() << " " << dateParameter.getHour() << ":" << dateParameter.getMinute() << ":" << dateParameter.getSecond() << R"lit(" ...)lit" << endl;
   }
   }
   else
   else
   {
   {