Browse Source

Fix SonarLint findings

Patrick-Christopher Mattulat 11 months ago
parent
commit
3b0272a135

+ 2 - 2
src/main/java/com/lynarstudios/ls/std/time/Library.java

@@ -4,8 +4,8 @@ public class Library
 {
   public final String getBinaryName()
   {
-    return binaryName;
+    return BINARY_NAME;
   }
 
-  private static final String binaryName = "ls-std-time";
+  private static final String BINARY_NAME = "ls-std-time";
 }

+ 3 - 1
src/main/java/com/lynarstudios/ls/std/time/systemtime/LocalDateTimeConverter.java

@@ -1,7 +1,6 @@
 package com.lynarstudios.ls.std.time.systemtime;
 
 import java.time.LocalDateTime;
-import java.time.ZoneId;
 
 public class LocalDateTimeConverter
 {
@@ -17,4 +16,7 @@ public class LocalDateTimeConverter
 
     return dateParameter;
   }
+
+  private LocalDateTimeConverter()
+  {}
 }

+ 2 - 2
src/test/java/com/lynarstudios/ls/std/time/LibraryTest.java

@@ -3,10 +3,10 @@ package com.lynarstudios.ls.std.time;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class LibraryTest
+class LibraryTest
 {
   @Test
-  public void getBinaryName()
+  void getBinaryName()
   {
     Assertions.assertEquals("ls-std-time", new Library().getBinaryName());
   }

+ 13 - 13
src/test/java/com/lynarstudios/ls/std/time/systemtime/DateParameterTest.java

@@ -8,7 +8,7 @@ class DateParameterTest
   private final DateParameter parameter = new DateParameter();
 
   @Test
-  public void constructor()
+  void constructor()
   {
     DateParameter dateParameter = new DateParameter(1989, (byte) 6, (byte) 1, (byte) 10, (byte) 52, (byte) 22);
 
@@ -21,78 +21,78 @@ class DateParameterTest
   }
 
   @Test
-  public void getDay()
+  void getDay()
   {
     Assertions.assertEquals(0, this.parameter.getDay());
   }
 
   @Test
-  public void getHour()
+  void getHour()
   {
     Assertions.assertEquals(0, this.parameter.getHour());
   }
 
   @Test
-  public void getMinute()
+  void getMinute()
   {
     Assertions.assertEquals(0, this.parameter.getMinute());
   }
 
   @Test
-  public void getMonth()
+  void getMonth()
   {
     Assertions.assertEquals(0, this.parameter.getMonth());
   }
 
   @Test
-  public void getSecond()
+  void getSecond()
   {
     Assertions.assertEquals(0, this.parameter.getSecond());
   }
 
   @Test
-  public void getYear()
+  void getYear()
   {
     Assertions.assertEquals(0, this.parameter.getYear());
   }
 
   @Test
-  public void setDay()
+  void setDay()
   {
     this.parameter.setDay((byte) 1);
     Assertions.assertEquals(1, this.parameter.getDay());
   }
 
   @Test
-  public void setHour()
+  void setHour()
   {
     this.parameter.setHour((byte) 10);
     Assertions.assertEquals(10, this.parameter.getHour());
   }
 
   @Test
-  public void setMinute()
+  void setMinute()
   {
     this.parameter.setMinute((byte) 52);
     Assertions.assertEquals(52, this.parameter.getMinute());
   }
 
   @Test
-  public void setMonth()
+  void setMonth()
   {
     this.parameter.setMonth((byte) 6);
     Assertions.assertEquals(6, this.parameter.getMonth());
   }
 
   @Test
-  public void setSecond()
+  void setSecond()
   {
     this.parameter.setSecond((byte) 22);
     Assertions.assertEquals(22, this.parameter.getSecond());
   }
 
   @Test
-  public void setYear()
+  void setYear()
   {
     this.parameter.setYear(1989);
     Assertions.assertEquals(1989, this.parameter.getYear());

+ 1 - 1
src/test/java/com/lynarstudios/ls/std/time/systemtime/LocalDateTimeConverterTest.java

@@ -8,7 +8,7 @@ import java.time.LocalDateTime;
 class LocalDateTimeConverterTest
 {
   @Test
-  public void toDateParameter()
+  void toDateParameter()
   {
     LocalDateTime localDateTime = LocalDateTime.of(2030, 6, 1, 10, 55, 13);
     DateParameter parameter = LocalDateTimeConverter.toDateParameter(localDateTime);